Codecov Report

❌ Patch coverage is 94.59459% with 6 lines in your changes missing coverage. Please review.

📢 Thoughts on this report? Let us know!

Thanks for your PR!

Would it be possible to split it up into 3 individual ones, one per new argument? That would make reviews much easier.

There could also be one .feature file per new argument for example. search-replace-new-options.feature doesn't really make sense (define new... what if we add even newer arguments two months from now 😄)

PS. Notice the lint failure

• Splitting the *.features: sure. I just did in this later commit (+ phpcs)

• But splitting logically the actual code changes seems over my forces.

1. It would have been humanly impossible for me develop them separately and keep them in sync one with the other and all against upstream branch across these many years and actually use them (maintaining a combined branch).
2. I think this was my last burst of motivation : if anything goes out of sync again, I'm too likely to just definitely give up

I understand it's a significant diff on core code, but: 175 insertions(+), 43 deletions(-) doesn't seem that much considering the amount of capabilities these new options brings to search-replace

• I don't understand the phpstan error:
  php -r '$r["post"]["*"][] = "c"; print_r($r);' is valid.

There is also at least one imperfection I'm aware of:

--where <table>:<col>:<cond> is actually adding <col> restrictions globally (not actually scoped to said table (reusing the logic of --include-columns). Moving the restriction more precisely, within the search and replace inner loops is probably doable, but would be even more complex (to write/assess and review).
It's better left to a future improvement (and the current logic is not breaking anything anyway)

What do you think is left to do ?

Just reviews at this point I think :-)

We have a lot of open PRs right now that we'll go through ahead of the next release.